Added expanded view for pixels/links. Made filter form into a popover.

This commit is contained in:
Mike Cao 2025-10-03 20:25:06 -07:00
parent 8971f23e72
commit fdfa8b08f9
4 changed files with 83 additions and 11 deletions

View file

@ -7,9 +7,30 @@ import { WebsiteChart } from '@/app/(main)/websites/[websiteId]/WebsiteChart';
import { LinkMetricsBar } from '@/app/(main)/links/[linkId]/LinkMetricsBar'; import { LinkMetricsBar } from '@/app/(main)/links/[linkId]/LinkMetricsBar';
import { LinkControls } from '@/app/(main)/links/[linkId]/LinkControls'; import { LinkControls } from '@/app/(main)/links/[linkId]/LinkControls';
import { LinkPanels } from '@/app/(main)/links/[linkId]/LinkPanels'; import { LinkPanels } from '@/app/(main)/links/[linkId]/LinkPanels';
import { Column, Grid } from '@umami/react-zen'; import { Column, Dialog, Grid, Modal } from '@umami/react-zen';
import { WebsiteExpandedView } from '@/app/(main)/websites/[websiteId]/WebsiteExpandedView';
import { useNavigation } from '@/components/hooks';
const excludedIds = ['path', 'entry', 'exit', 'title', 'language', 'screen', 'event'];
export function LinkPage({ linkId }: { linkId: string }) { export function LinkPage({ linkId }: { linkId: string }) {
const {
router,
query: { view },
updateParams,
} = useNavigation();
const handleClose = (close: () => void) => {
router.push(updateParams({ view: undefined }));
close();
};
const handleOpenChange = (isOpen: boolean) => {
if (!isOpen) {
router.push(updateParams({ view: undefined }));
}
};
return ( return (
<LinkProvider linkId={linkId}> <LinkProvider linkId={linkId}>
<Grid width="100%" height="100%"> <Grid width="100%" height="100%">
@ -23,6 +44,19 @@ export function LinkPage({ linkId }: { linkId: string }) {
</Panel> </Panel>
<LinkPanels linkId={linkId} /> <LinkPanels linkId={linkId} />
</PageBody> </PageBody>
<Modal isOpen={!!view} onOpenChange={handleOpenChange} isDismissable>
<Dialog style={{ maxWidth: 1320, width: '100vw', height: 'calc(100vh - 40px)' }}>
{({ close }) => {
return (
<WebsiteExpandedView
websiteId={linkId}
excludedIds={excludedIds}
onClose={() => handleClose(close)}
/>
);
}}
</Dialog>
</Modal>
</Column> </Column>
</Grid> </Grid>
</LinkProvider> </LinkProvider>

View file

@ -7,9 +7,30 @@ import { WebsiteChart } from '@/app/(main)/websites/[websiteId]/WebsiteChart';
import { PixelMetricsBar } from '@/app/(main)/pixels/[pixelId]/PixelMetricsBar'; import { PixelMetricsBar } from '@/app/(main)/pixels/[pixelId]/PixelMetricsBar';
import { PixelControls } from '@/app/(main)/pixels/[pixelId]/PixelControls'; import { PixelControls } from '@/app/(main)/pixels/[pixelId]/PixelControls';
import { PixelPanels } from '@/app/(main)/pixels/[pixelId]/PixelPanels'; import { PixelPanels } from '@/app/(main)/pixels/[pixelId]/PixelPanels';
import { Column, Grid } from '@umami/react-zen'; import { Column, Dialog, Grid, Modal } from '@umami/react-zen';
import { WebsiteExpandedView } from '@/app/(main)/websites/[websiteId]/WebsiteExpandedView';
import { useNavigation } from '@/components/hooks';
const excludedIds = ['path', 'entry', 'exit', 'title', 'language', 'screen', 'event'];
export function PixelPage({ pixelId }: { pixelId: string }) { export function PixelPage({ pixelId }: { pixelId: string }) {
const {
router,
query: { view },
updateParams,
} = useNavigation();
const handleClose = (close: () => void) => {
router.push(updateParams({ view: undefined }));
close();
};
const handleOpenChange = (isOpen: boolean) => {
if (!isOpen) {
router.push(updateParams({ view: undefined }));
}
};
return ( return (
<PixelProvider pixelId={pixelId}> <PixelProvider pixelId={pixelId}>
<Grid width="100%" height="100%"> <Grid width="100%" height="100%">
@ -23,6 +44,19 @@ export function PixelPage({ pixelId }: { pixelId: string }) {
</Panel> </Panel>
<PixelPanels pixelId={pixelId} /> <PixelPanels pixelId={pixelId} />
</PageBody> </PageBody>
<Modal isOpen={!!view} onOpenChange={handleOpenChange} isDismissable>
<Dialog style={{ maxWidth: 1320, width: '100vw', height: 'calc(100vh - 40px)' }}>
{({ close }) => {
return (
<WebsiteExpandedView
websiteId={pixelId}
excludedIds={excludedIds}
onClose={() => handleClose(close)}
/>
);
}}
</Dialog>
</Modal>
</Column> </Column>
</Grid> </Grid>
</PixelProvider> </PixelProvider>

View file

@ -26,9 +26,11 @@ import { Lightning } from '@/components/svg';
export function WebsiteExpandedView({ export function WebsiteExpandedView({
websiteId, websiteId,
excludedIds = [],
onClose, onClose,
}: { }: {
websiteId: string; websiteId: string;
excludedIds?: string[];
onClose?: () => void; onClose?: () => void;
}) { }) {
const { formatMessage, labels } = useMessages(); const { formatMessage, labels } = useMessages();
@ -37,9 +39,11 @@ export function WebsiteExpandedView({
query: { view }, query: { view },
} = useNavigation(); } = useNavigation();
const filterExcluded = (item: { id: string }) => !excludedIds.includes(item.id);
const items = [ const items = [
{ {
label: formatMessage(labels.pages), label: 'URL',
items: [ items: [
{ {
id: 'path', id: 'path',
@ -71,7 +75,7 @@ export function WebsiteExpandedView({
path: updateParams({ view: 'query' }), path: updateParams({ view: 'query' }),
icon: <Search />, icon: <Search />,
}, },
], ].filter(filterExcluded),
}, },
{ {
label: formatMessage(labels.sources), label: formatMessage(labels.sources),
@ -94,7 +98,7 @@ export function WebsiteExpandedView({
path: updateParams({ view: 'domain' }), path: updateParams({ view: 'domain' }),
icon: <Globe />, icon: <Globe />,
}, },
], ].filter(filterExcluded),
}, },
{ {
label: formatMessage(labels.location), label: formatMessage(labels.location),
@ -117,7 +121,7 @@ export function WebsiteExpandedView({
path: updateParams({ view: 'city' }), path: updateParams({ view: 'city' }),
icon: <Landmark />, icon: <Landmark />,
}, },
], ].filter(filterExcluded),
}, },
{ {
label: formatMessage(labels.environment), label: formatMessage(labels.environment),
@ -152,7 +156,7 @@ export function WebsiteExpandedView({
path: updateParams({ view: 'screen' }), path: updateParams({ view: 'screen' }),
icon: <Monitor />, icon: <Monitor />,
}, },
], ].filter(filterExcluded),
}, },
{ {
label: formatMessage(labels.other), label: formatMessage(labels.other),
@ -175,7 +179,7 @@ export function WebsiteExpandedView({
path: updateParams({ view: 'tag' }), path: updateParams({ view: 'tag' }),
icon: <Tag />, icon: <Tag />,
}, },
], ].filter(filterExcluded),
}, },
]; ];

View file

@ -1,4 +1,4 @@
import { Button, Icon, DialogTrigger, Dialog, Modal, Text } from '@umami/react-zen'; import { Button, Icon, DialogTrigger, Dialog, Popover, Text } from '@umami/react-zen';
import { ListFilter } from '@/components/icons'; import { ListFilter } from '@/components/icons';
import { FilterEditForm } from '@/components/input/FilterEditForm'; import { FilterEditForm } from '@/components/input/FilterEditForm';
import { useMessages, useNavigation } from '@/components/hooks'; import { useMessages, useNavigation } from '@/components/hooks';
@ -32,13 +32,13 @@ export function WebsiteFilterButton({
</Icon> </Icon>
{showText && <Text>{formatMessage(labels.filter)}</Text>} {showText && <Text>{formatMessage(labels.filter)}</Text>}
</Button> </Button>
<Modal> <Popover placement="bottom start">
<Dialog title={formatMessage(labels.filters)} style={{ width: 800, minHeight: 600 }}> <Dialog title={formatMessage(labels.filters)} style={{ width: 800, minHeight: 600 }}>
{({ close }) => { {({ close }) => {
return <FilterEditForm websiteId={websiteId} onChange={handleChange} onClose={close} />; return <FilterEditForm websiteId={websiteId} onChange={handleChange} onClose={close} />;
}} }}
</Dialog> </Dialog>
</Modal> </Popover>
</DialogTrigger> </DialogTrigger>
); );
} }