watson/umami
1
0
Fork 0
mirror of https://github.com/umami-software/umami.git synced 2026-02-20 20:45:39 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Make custom pageview data attribute prefix shorter

Browse source 
Since we're on the script element, no need to namespace the attribute with "umami", using data-event-* is enough
This commit is contained in:
Ewen Le Bihan 2023-12-17 01:07:46 +01:00
parent 1fd997c374
commit f45f7f5819
1 changed files with 3 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/tracker/index.js
View file

@ -26,6 +26,7 @@
const endpoint = `${root}/api/send`; const endpoint = `${root}/api/send`;
const screen = `${width}x${height}`; const screen = `${width}x${height}`;
const eventRegex = /data-umami-event-([\w-_]+)/; const eventRegex = /data-umami-event-([\w-_]+)/;
const pageviewCustomPropertyRegex = /data-event-([\w-_]+)/;
const eventNameAttribute = _data + 'umami-event'; const eventNameAttribute = _data + 'umami-event';
const delayDuration = 300; const delayDuration = 300;
@ -41,9 +42,9 @@
const getPageviewEventData = () => Object.fromEntries( const getPageviewEventData = () => Object.fromEntries(
[...currentScript.attributes] [...currentScript.attributes]
.filter(attribute => eventRegex.match(attribute.name)) .filter(attribute => pageviewCustomPropertyRegex.match(attribute.name))
.map(attribute => { .map(attribute => {
const match = attribute.name.match(eventRegex); const match = pageviewCustomPropertyRegex.match(attribute.name);
return [match[1], attribute.value] return [match[1], attribute.value]
}) })
) )