watson/umami
1
0
Fork 0
mirror of https://github.com/umami-software/umami.git synced 2025-12-08 05:12:36 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 5

fix: add visitor_id to coalesce chain for accurate visitor deduplication

Browse source 
Fixes visitor inflation bug where same person was counted twice:
- Once as session_id (before identify)
- Once as distinct_id (after identify)

The coalesce chain now uses visitor_id as fallback before session_id,
ensuring consistent counting across the identify() boundary.
This commit is contained in:
Arthur Sepiol 2025-12-03 17:02:29 +03:00
parent 34db34759f
commit ecf0b7bef4
1 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
src/queries/sql/getWebsiteStats.ts
View file

@ -37,7 +37,7 @@ async function relationalQuery(
` `
select select
cast(coalesce(sum(t.c), 0) as bigint) as "pageviews", cast(coalesce(sum(t.c), 0) as bigint) as "pageviews",
count(distinct coalesce(t.resolved_identity, t.session_id::text)) as "visitors", count(distinct coalesce(t.resolved_identity, t.visitor_id, t.session_id::text)) as "visitors",
count(distinct t.visit_id) as "visits", count(distinct t.visit_id) as "visits",
coalesce(sum(case when t.c = 1 then 1 else 0 end), 0) as "bounces", coalesce(sum(case when t.c = 1 then 1 else 0 end), 0) as "bounces",
cast(coalesce(sum(${getTimestampDiffSQL('t.min_time', 't.max_time')}), 0) as bigint) as "totaltime" cast(coalesce(sum(${getTimestampDiffSQL('t.min_time', 't.max_time')}), 0) as bigint) as "totaltime"
@ -45,6 +45,7 @@ async function relationalQuery(
select select
website_event.session_id, website_event.session_id,
website_event.visit_id, website_event.visit_id,
session.visitor_id,
il.distinct_id as "resolved_identity", il.distinct_id as "resolved_identity",
count(*) as "c", count(*) as "c",
min(website_event.created_at) as "min_time", min(website_event.created_at) as "min_time",
@ -60,7 +61,7 @@ async function relationalQuery(
and website_event.created_at between {{startDate}} and {{endDate}} and website_event.created_at between {{startDate}} and {{endDate}}
and website_event.event_type != 2 and website_event.event_type != 2
${filterQuery} ${filterQuery}
group by 1, 2, 3 group by 1, 2, 3, 4
) as t ) as t
`, `,
queryParams, queryParams,
@ -84,7 +85,7 @@ async function clickhouseQuery(
sql = ` sql = `
select select
sum(t.c) as "pageviews", sum(t.c) as "pageviews",
uniq(coalesce(t.resolved_identity, toString(t.session_id))) as "visitors", uniq(coalesce(t.resolved_identity, t.visitor_id, toString(t.session_id))) as "visitors",
uniq(t.visit_id) as "visits", uniq(t.visit_id) as "visits",
sum(if(t.c = 1, 1, 0)) as "bounces", sum(if(t.c = 1, 1, 0)) as "bounces",
sum(max_time-min_time) as "totaltime" sum(max_time-min_time) as "totaltime"
@ -92,6 +93,7 @@ async function clickhouseQuery(
select select
we.session_id, we.session_id,
we.visit_id, we.visit_id,
we.visitor_id,
il.distinct_id as resolved_identity, il.distinct_id as resolved_identity,
count(*) c, count(*) c,
min(we.created_at) min_time, min(we.created_at) min_time,
@ -104,20 +106,21 @@ async function clickhouseQuery(
and we.created_at between {startDate:DateTime64} and {endDate:DateTime64} and we.created_at between {startDate:DateTime64} and {endDate:DateTime64}
and we.event_type != 2 and we.event_type != 2
${filterQuery} ${filterQuery}
group by we.session_id, we.visit_id, il.distinct_id group by we.session_id, we.visit_id, we.visitor_id, il.distinct_id
) as t; ) as t;
`; `;
} else { } else {
sql = ` sql = `
select select
sum(t.c) as "pageviews", sum(t.c) as "pageviews",
uniq(coalesce(resolved_identity, toString(session_id))) as "visitors", uniq(coalesce(resolved_identity, visitor_id, toString(session_id))) as "visitors",
uniq(visit_id) as "visits", uniq(visit_id) as "visits",
sumIf(1, t.c = 1) as "bounces", sumIf(1, t.c = 1) as "bounces",
sum(max_time-min_time) as "totaltime" sum(max_time-min_time) as "totaltime"
from (select from (select
we.session_id, we.session_id,
we.visit_id, we.visit_id,
we.visitor_id,
il.distinct_id as resolved_identity, il.distinct_id as resolved_identity,
sum(we.views) c, sum(we.views) c,
min(we.min_time) min_time, min(we.min_time) min_time,
@ -130,7 +133,7 @@ async function clickhouseQuery(
and we.created_at between {startDate:DateTime64} and {endDate:DateTime64} and we.created_at between {startDate:DateTime64} and {endDate:DateTime64}
and we.event_type != 2 and we.event_type != 2
${filterQuery} ${filterQuery}
group by we.session_id, we.visit_id, il.distinct_id group by we.session_id, we.visit_id, we.visitor_id, il.distinct_id
) as t; ) as t;
`; `;
} }