Revert "add none/direct back to referrers table"

This reverts commit 10a31a7513.
This commit is contained in:
Francis Cao 2025-02-04 15:45:51 -08:00
parent 53cd32542e
commit d7f20dd3bf
5 changed files with 6 additions and 6 deletions

2
next-env.d.ts vendored
View file

@ -3,4 +3,4 @@
/// <reference types="next/navigation-types/compat/navigation" />
// NOTE: This file should not be edited
// see https://nextjs.org/docs/app/building-your-application/configuring/typescript for more information.
// see https://nextjs.org/docs/app/api-reference/config/typescript for more information.

View file

@ -42,7 +42,7 @@ export function FilterLink({
{safeDecodeURIComponent(label || value)}
</Link>
)}
{value && (
{externalUrl && (
<a className={styles.link} href={externalUrl} target="_blank" rel="noreferrer noopener">
<Icon className={styles.icon}>
<Icons.External />

View file

@ -113,7 +113,6 @@ export const labels = defineMessages({
filterRaw: { id: 'label.filter-raw', defaultMessage: 'Raw' },
views: { id: 'label.views', defaultMessage: 'Views' },
none: { id: 'label.none', defaultMessage: 'None' },
directNone: { id: 'label.direct-none', defaultMessage: 'Direct / None' },
clearAll: { id: 'label.clear-all', defaultMessage: 'Clear all' },
property: { id: 'label.property', defaultMessage: 'Property' },
today: { id: 'label.today', defaultMessage: 'Today' },

View file

@ -12,7 +12,7 @@ export function ReferrersTable(props: MetricsTableProps) {
id="referrer"
value={referrer}
externalUrl={`https://${referrer}`}
label={!referrer && formatMessage(labels.directNone)}
label={!referrer && formatMessage(labels.none)}
>
<Favicon domain={referrer} />
</FilterLink>

View file

@ -34,7 +34,8 @@ async function relationalQuery(
let entryExitQuery = '';
let excludeDomain = '';
if (column === 'referrer_domain') {
excludeDomain = `and website_event.referrer_domain != {{websiteDomain}}`;
excludeDomain = `and website_event.referrer_domain != {{websiteDomain}}
and website_event.referrer_domain is not null`;
}
if (type === 'entry' || type === 'exit') {
@ -96,7 +97,7 @@ async function clickhouseQuery(
let entryExitQuery = '';
if (column === 'referrer_domain') {
excludeDomain = `and referrer_domain != {websiteDomain:String}`;
excludeDomain = `and referrer_domain != {websiteDomain:String} and referrer_domain != ''`;
}
if (type === 'entry' || type === 'exit') {