Refactored referrer logic. Display stats for no referrers.

lib/filters.js

@@ -1,14 +1,10 @@
-import { removeTrailingSlash, removeWWW, getDomainName } from './url';
+import { removeWWW } from './url';
 
-export const urlFilter = (data, { raw }) => {
+export const urlFilter = data => {
   const isValidUrl = url => {
     return url !== '' && url !== null && !url.startsWith('#');
   };
 
-  if (raw) {
-    return data.filter(({ x }) => isValidUrl(x));
-  }
-
   const cleanUrl = url => {
     try {
       const { pathname, search } = new URL(url, location.origin);
@@ -44,68 +40,26 @@ export const urlFilter = (data, { raw }) => {
   return Object.keys(map).map(key => ({ x: key, y: map[key] }));
 };
 
-export const refFilter = (data, { domain, domainOnly, raw }) => {
-  const domainName = getDomainName(domain);
-  const regex = new RegExp(`http[s]?://([a-z0-9-]+\\.)*${domainName}`);
+export const refFilter = data => {
   const links = {};
 
-  const isValidRef = referrer => {
-    return referrer !== null && !referrer.startsWith('/') && !referrer.startsWith('#');
-  };
-
-  const cleanUrl = url => {
-    try {
-      if (url === '') {
-        return 'Direct / None';
-      }
-
-      const { hostname, origin, pathname, searchParams, protocol } = new URL(url);
-
-      if (regex.test(url)) {
-        return null;
-      }
-
-      if (domainOnly && hostname) {
-        return removeWWW(hostname);
-      }
-
-      if (!origin || origin === 'null') {
-        return `${protocol}${removeTrailingSlash(pathname)}`;
-      }
-
-      if (protocol.startsWith('http')) {
-        const path = removeTrailingSlash(pathname);
-        const referrer = searchParams.get('referrer');
-        const query = referrer ? `?referrer=${referrer}` : '';
-
-        return removeTrailingSlash(`${removeWWW(hostname)}${path}`) + query;
-      }
-
-      return null;
-    } catch {
-      return null;
-    }
-  };
-
-  if (raw) {
-    return data.filter(({ x }) => isValidRef(x) && !regex.test(x));
-  }
-
   const map = data.reduce((obj, { x, y }) => {
-    if (!isValidRef(x)) {
-      return obj;
+    let id;
+
+    try {
+      const url = new URL(x);
+
+      id = removeWWW(url.hostname) || url.href;
+    } catch {
+      id = '';
     }
 
-    const url = cleanUrl(x);
+    links[id] = x;
 
-    links[url] = x;
-
-    if (url) {
-      if (!obj[url]) {
-        obj[url] = y;
-      } else {
-        obj[url] += y;
-      }
+    if (!obj[id]) {
+      obj[id] = y;
+    } else {
+      obj[id] += y;
     }
 
     return obj;

lib/queries.js

@@ -59,11 +59,11 @@ export function getTimestampInterval(field) {
   }
 }
 
-export function getFilterQuery(table, filters = {}, params = []) {
+export function getFilterQuery(table, column, filters = {}, params = []) {
   const query = Object.keys(filters).reduce((arr, key) => {
     const value = filters[key];
 
-    if (value === undefined) {
+    if (!value || value === true) {
       return arr;
     }
 
@@ -94,7 +94,8 @@ export function getFilterQuery(table, filters = {}, params = []) {
 
       case 'referrer':
         if (table === 'pageview') {
-          arr.push(`and ${table}.referrer like $${params.length + 1}`);
+          arr.push(`and ${table}.referrer like $${params.length + 1} `);
+          arr.push(`and ${table}.referrer not like '/%'`);
           params.push(`%${decodeURIComponent(value)}%`);
         }
         break;
@@ -114,7 +115,7 @@ export function getFilterQuery(table, filters = {}, params = []) {
   return query.join('\n');
 }
 
-export function parseFilters(table, filters = {}, params = []) {
+export function parseFilters(table, column, filters = {}, params = []) {
   const { domain, url, event_url, referrer, os, browser, device, country, event_type } = filters;
 
   const pageviewFilters = { domain, url, referrer };
@@ -130,9 +131,9 @@ export function parseFilters(table, filters = {}, params = []) {
       os || browser || device || country
         ? `inner join session on ${table}.session_id = session.session_id`
         : '',
-    pageviewQuery: getFilterQuery('pageview', pageviewFilters, params),
-    sessionQuery: getFilterQuery('session', sessionFilters, params),
-    eventQuery: getFilterQuery('event', eventFilters, params),
+    pageviewQuery: getFilterQuery('pageview', column, pageviewFilters, params),
+    sessionQuery: getFilterQuery('session', column, sessionFilters, params),
+    eventQuery: getFilterQuery('event', column, eventFilters, params),
   };
 }
 

lib/url.js

@@ -6,14 +6,6 @@ export function removeWWW(url) {
   return url && url.length > 1 && url.startsWith('www.') ? url.slice(4) : url;
 }
 
-export function getDomainName(str) {
-  try {
-    return new URL(str).hostname;
-  } catch (e) {
-    return str;
-  }
-}
-
 export function getQueryString(params = {}) {
   const map = Object.keys(params).reduce((arr, key) => {
     if (params[key] !== undefined) {