watson/umami
1
0
Fork 0
mirror of https://github.com/umami-software/umami.git synced 2026-02-10 07:37:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Merge pull request #3469 from KrakenWagen/create_session_slow

Browse source 
improv: Improved performance of send
This commit is contained in:
Mike Cao 2025-06-18 14:29:03 -07:00 • committed by GitHub
commit acc323dbc9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 49 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

44
src/app/api/send/route.ts
View file

@ -4,7 +4,7 @@ import { startOfHour, startOfMonth } from 'date-fns';
import clickhouse from '@/lib/clickhouse'; import clickhouse from '@/lib/clickhouse';
import { parseRequest } from '@/lib/request'; import { parseRequest } from '@/lib/request';
import { badRequest, json, forbidden, serverError } from '@/lib/response'; import { badRequest, json, forbidden, serverError } from '@/lib/response';
import { fetchSession, fetchWebsite } from '@/lib/load'; import { fetchWebsite } from '@/lib/load';
import { getClientInfo, hasBlockedIp } from '@/lib/detect'; import { getClientInfo, hasBlockedIp } from '@/lib/detect';
import { createToken, parseToken } from '@/lib/jwt'; import { createToken, parseToken } from '@/lib/jwt';
import { secret, uuid, hash } from '@/lib/crypto'; import { secret, uuid, hash } from '@/lib/crypto';
@ -103,32 +103,24 @@ export async function POST(request: Request) {
const sessionId = id ? uuid(websiteId, id) : uuid(websiteId, ip, userAgent, sessionSalt); const sessionId = id ? uuid(websiteId, id) : uuid(websiteId, ip, userAgent, sessionSalt);
// Find session // Create a session if not found
if (!clickhouse.enabled && !cache?.sessionId) { if (!clickhouse.enabled && !cache?.sessionId) {
const session = await fetchSession(websiteId, sessionId); await createSession(
{
// Create a session if not found id: sessionId,
if (!session) { websiteId,
try { browser,
await createSession({ os,
id: sessionId, device,
websiteId, screen,
browser, language,
os, country,
device, region,
screen, city,
language, distinctId: id,
country, },
region, { skipDuplicates: true },
city, );
distinctId: id,
});
} catch (e: any) {
if (!e.message.toLowerCase().includes('unique constraint')) {
return serverError(e);
}
}
}
} }
// Visit info // Visit info

47
src/queries/sql/sessions/createSession.ts
View file

@ -1,7 +1,10 @@
import { Prisma } from '@prisma/client'; import { Prisma } from '@prisma/client';
import prisma from '@/lib/prisma'; import prisma from '@/lib/prisma';
export async function createSession(data: Prisma.SessionCreateInput) { export async function createSession(
data: Prisma.SessionCreateInput,
options = { skipDuplicates: false },
) {
const { const {
id, id,
websiteId, websiteId,
@ -16,19 +19,31 @@ export async function createSession(data: Prisma.SessionCreateInput) {
distinctId, distinctId,
} = data; } = data;
return prisma.client.session.create({ try {
data: { return await prisma.client.session.create({
id, data: {
websiteId, id,
browser, websiteId,
os, browser,
device, os,
screen, device,
language, screen,
country, language,
region, country,
city, region,
distinctId, city,
}, distinctId,
}); },
});
} catch (e: any) {
// With skipDuplicates flag: ignore unique constraint error and return null
if (
options.skipDuplicates &&
e instanceof Prisma.PrismaClientKnownRequestError &&
e.code === 'P2002'
) {
return null;
}
throw e;
}
} }