From 909a96d4585ae557957c9a6abb500c75a4e700b9 Mon Sep 17 00:00:00 2001 From: Mike Cao Date: Sun, 10 Mar 2024 03:26:47 -0700 Subject: [PATCH] Fixed issue with long page titles. --- src/lib/constants.ts | 1 + src/queries/analytics/events/saveEvent.ts | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/src/lib/constants.ts b/src/lib/constants.ts index f728837a0..b5d30a985 100644 --- a/src/lib/constants.ts +++ b/src/lib/constants.ts @@ -224,6 +224,7 @@ export const LAPTOP_SCREEN_WIDTH = 1024; export const MOBILE_SCREEN_WIDTH = 479; export const URL_LENGTH = 500; +export const PAGE_TITLE_LENGTH = 500; export const EVENT_NAME_LENGTH = 50; export const DESKTOP_OS = [ diff --git a/src/queries/analytics/events/saveEvent.ts b/src/queries/analytics/events/saveEvent.ts index a6457d7e6..0596023b4 100644 --- a/src/queries/analytics/events/saveEvent.ts +++ b/src/queries/analytics/events/saveEvent.ts @@ -1,4 +1,4 @@ -import { EVENT_NAME_LENGTH, URL_LENGTH, EVENT_TYPE } from 'lib/constants'; +import { EVENT_NAME_LENGTH, URL_LENGTH, EVENT_TYPE, PAGE_TITLE_LENGTH } from 'lib/constants'; import { CLICKHOUSE, PRISMA, runQuery } from 'lib/db'; import kafka from 'lib/kafka'; import prisma from 'lib/prisma'; @@ -69,7 +69,7 @@ async function relationalQuery(data: { referrerPath: referrerPath?.substring(0, URL_LENGTH), referrerQuery: referrerQuery?.substring(0, URL_LENGTH), referrerDomain: referrerDomain?.substring(0, URL_LENGTH), - pageTitle, + pageTitle: pageTitle?.substring(0, PAGE_TITLE_LENGTH), eventType: eventName ? EVENT_TYPE.customEvent : EVENT_TYPE.pageView, eventName: eventName ? eventName?.substring(0, EVENT_NAME_LENGTH) : null, }, @@ -151,7 +151,7 @@ async function clickhouseQuery(data: { referrer_path: referrerPath?.substring(0, URL_LENGTH), referrer_query: referrerQuery?.substring(0, URL_LENGTH), referrer_domain: referrerDomain?.substring(0, URL_LENGTH), - page_title: pageTitle, + page_title: pageTitle?.substring(0, PAGE_TITLE_LENGTH), event_type: eventName ? EVENT_TYPE.customEvent : EVENT_TYPE.pageView, event_name: eventName ? eventName?.substring(0, EVENT_NAME_LENGTH) : null, created_at: createdAt,