From 907685b96e0caae51846fc6dfe55d9ddfe16d7cd Mon Sep 17 00:00:00 2001
From: Mike Cao <mike@mikecao.com>
Date: Tue, 12 Dec 2023 19:00:44 -0800
Subject: [PATCH] Added limit to metrics queries.

---
 .../(main)/websites/[id]/WebsiteExpandedView.tsx   |  1 -
 src/components/metrics/MetricsTable.tsx            |  1 +
 src/lib/prisma.ts                                  |  6 +++++-
 src/lib/types.ts                                   |  1 +
 src/pages/api/websites/[id]/metrics.ts             |  7 +++++--
 .../analytics/pageviews/getPageviewMetrics.ts      | 14 ++++++++++----
 .../analytics/sessions/getSessionMetrics.ts        | 14 ++++++++++----
 7 files changed, 32 insertions(+), 12 deletions(-)

diff --git a/src/app/(main)/websites/[id]/WebsiteExpandedView.tsx b/src/app/(main)/websites/[id]/WebsiteExpandedView.tsx
index e97cd002..9fb1b3f6 100644
--- a/src/app/(main)/websites/[id]/WebsiteExpandedView.tsx
+++ b/src/app/(main)/websites/[id]/WebsiteExpandedView.tsx
@@ -144,7 +144,6 @@ export default function WebsiteExpandedView({
         <DetailsComponent
           websiteId={websiteId}
           websiteDomain={websiteDomain}
-          limit={false}
           animate={false}
           virtualize={true}
           itemCount={25}
diff --git a/src/components/metrics/MetricsTable.tsx b/src/components/metrics/MetricsTable.tsx
index 48beac68..77e70311 100644
--- a/src/components/metrics/MetricsTable.tsx
+++ b/src/components/metrics/MetricsTable.tsx
@@ -77,6 +77,7 @@ export function MetricsTable({
         type,
         startAt: +startDate,
         endAt: +endDate,
+        limit,
         ...filters,
       });
 
diff --git a/src/lib/prisma.ts b/src/lib/prisma.ts
index 2abf230c..cb119bb8 100644
--- a/src/lib/prisma.ts
+++ b/src/lib/prisma.ts
@@ -135,7 +135,11 @@ function normalizeFilters(filters = {}) {
   }, {});
 }
 
-async function parseFilters(websiteId, filters: QueryFilters = {}, options: QueryOptions = {}) {
+async function parseFilters(
+  websiteId: string,
+  filters: QueryFilters = {},
+  options: QueryOptions = {},
+) {
   const website = await loadWebsite(websiteId);
 
   return {
diff --git a/src/lib/types.ts b/src/lib/types.ts
index 900f2e5a..af0ea0f7 100644
--- a/src/lib/types.ts
+++ b/src/lib/types.ts
@@ -206,6 +206,7 @@ export interface QueryFilters {
 export interface QueryOptions {
   joinSession?: boolean;
   columns?: { [key: string]: string };
+  limit?: number;
 }
 
 export interface RealtimeData {
diff --git a/src/pages/api/websites/[id]/metrics.ts b/src/pages/api/websites/[id]/metrics.ts
index 56b0b066..91cc7f7d 100644
--- a/src/pages/api/websites/[id]/metrics.ts
+++ b/src/pages/api/websites/[id]/metrics.ts
@@ -25,6 +25,7 @@ export interface WebsiteMetricsRequestQuery {
   city?: string;
   language?: string;
   event?: string;
+  limit?: number;
 }
 
 const schema = {
@@ -45,6 +46,7 @@ const schema = {
     city: yup.string(),
     language: yup.string(),
     event: yup.string(),
+    limit: yup.number(),
   }),
 };
 
@@ -71,6 +73,7 @@ export default async (
     city,
     language,
     event,
+    limit,
   } = req.query;
 
   if (req.method === 'GET') {
@@ -100,7 +103,7 @@ export default async (
     const column = FILTER_COLUMNS[type] || type;
 
     if (SESSION_COLUMNS.includes(type)) {
-      const data = await getSessionMetrics(websiteId, column, filters);
+      const data = await getSessionMetrics(websiteId, column, filters, limit);
 
       if (type === 'language') {
         const combined = {};
@@ -122,7 +125,7 @@ export default async (
     }
 
     if (EVENT_COLUMNS.includes(type)) {
-      const data = await getPageviewMetrics(websiteId, column, filters);
+      const data = await getPageviewMetrics(websiteId, column, filters, limit);
 
       return ok(res, data);
     }
diff --git a/src/queries/analytics/pageviews/getPageviewMetrics.ts b/src/queries/analytics/pageviews/getPageviewMetrics.ts
index 4e7e9da2..b7aef81c 100644
--- a/src/queries/analytics/pageviews/getPageviewMetrics.ts
+++ b/src/queries/analytics/pageviews/getPageviewMetrics.ts
@@ -5,7 +5,7 @@ import { EVENT_TYPE, SESSION_COLUMNS } from 'lib/constants';
 import { QueryFilters } from 'lib/types';
 
 export async function getPageviewMetrics(
-  ...args: [websiteId: string, columns: string, filters: QueryFilters]
+  ...args: [websiteId: string, columns: string, filters: QueryFilters, limit?: number]
 ) {
   return runQuery({
     [PRISMA]: () => relationalQuery(...args),
@@ -13,7 +13,12 @@ export async function getPageviewMetrics(
   });
 }
 
-async function relationalQuery(websiteId: string, column: string, filters: QueryFilters) {
+async function relationalQuery(
+  websiteId: string,
+  column: string,
+  filters: QueryFilters,
+  limit: number = 100,
+) {
   const { rawQuery, parseFilters } = prisma;
   const { filterQuery, joinSession, params } = await parseFilters(
     websiteId,
@@ -42,7 +47,7 @@ async function relationalQuery(websiteId: string, column: string, filters: Query
       ${filterQuery}
     group by 1
     order by 2 desc
-    limit 100
+    limit ${limit}
     `,
     params,
   );
@@ -52,6 +57,7 @@ async function clickhouseQuery(
   websiteId: string,
   column: string,
   filters: QueryFilters,
+  limit: number = 100,
 ): Promise<{ x: string; y: number }[]> {
   const { rawQuery, parseFilters } = clickhouse;
   const { filterQuery, params } = await parseFilters(websiteId, {
@@ -75,7 +81,7 @@ async function clickhouseQuery(
       ${filterQuery}
     group by x
     order by y desc
-    limit 100
+    limit ${limit}
     `,
     params,
   ).then(a => {
diff --git a/src/queries/analytics/sessions/getSessionMetrics.ts b/src/queries/analytics/sessions/getSessionMetrics.ts
index 3573ac1e..c6877a3f 100644
--- a/src/queries/analytics/sessions/getSessionMetrics.ts
+++ b/src/queries/analytics/sessions/getSessionMetrics.ts
@@ -5,7 +5,7 @@ import { EVENT_TYPE, SESSION_COLUMNS } from 'lib/constants';
 import { QueryFilters } from 'lib/types';
 
 export async function getSessionMetrics(
-  ...args: [websiteId: string, column: string, filters: QueryFilters]
+  ...args: [websiteId: string, column: string, filters: QueryFilters, limit?: number]
 ) {
   return runQuery({
     [PRISMA]: () => relationalQuery(...args),
@@ -13,7 +13,12 @@ export async function getSessionMetrics(
   });
 }
 
-async function relationalQuery(websiteId: string, column: string, filters: QueryFilters) {
+async function relationalQuery(
+  websiteId: string,
+  column: string,
+  filters: QueryFilters,
+  limit: number = 100,
+) {
   const { parseFilters, rawQuery } = prisma;
   const { filterQuery, joinSession, params } = await parseFilters(
     websiteId,
@@ -42,7 +47,7 @@ async function relationalQuery(websiteId: string, column: string, filters: Query
     group by 1 
     ${includeCountry ? ', 3' : ''}
     order by 2 desc
-    limit 100`,
+    limit ${limit}`,
     params,
   );
 }
@@ -51,6 +56,7 @@ async function clickhouseQuery(
   websiteId: string,
   column: string,
   filters: QueryFilters,
+  limit: number = 100,
 ): Promise<{ x: string; y: number }[]> {
   const { parseFilters, rawQuery } = clickhouse;
   const { filterQuery, params } = await parseFilters(websiteId, {
@@ -73,7 +79,7 @@ async function clickhouseQuery(
     group by x 
     ${includeCountry ? ', country' : ''}
     order by y desc
-    limit 100
+    limit ${limit}
     `,
     params,
   ).then(a => {