watson/umami
1
0
Fork 0
mirror of https://github.com/umami-software/umami.git synced 2026-02-20 20:45:39 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix: remove async script attribute

Browse source 
using async and defer on script tags is considered an [antipattern](https://almanac.httparchive.org/en/2022/javascript#async-defer-module-and-nomodule) as defer will be ignored. Defer is the preferred behaviour in most situations.
This commit is contained in:
Sam Vargas 2023-01-05 12:54:07 +00:00
parent 796c65fa29
commit 258e8bb3d6
2 changed files with 1 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/forms/TrackingCodeForm.js
View file

@ -5,7 +5,7 @@ import { Form, FormRow, TextArea } from 'react-basics';
export default function TrackingCodeForm({ websiteId }) {
const ref = useRef(null);
const { trackerScriptName } = useConfig();
const code = `<script async defer src="${trackerScriptName}" data-website-id="${websiteId}"></script>`;
const code = `<script defer src="${trackerScriptName}" data-website-id="${websiteId}"></script>`;
return (
<>