diff --git a/src/components/metrics/ChangeLabel.module.css b/src/components/metrics/ChangeLabel.module.css index 110f9a0d..802a9931 100644 --- a/src/components/metrics/ChangeLabel.module.css +++ b/src/components/metrics/ChangeLabel.module.css @@ -24,8 +24,3 @@ color: var(--base700); background: var(--base100); } - -.new { - color: var(--blue900); - background: var(--blue100); -} diff --git a/src/components/metrics/ChangeLabel.tsx b/src/components/metrics/ChangeLabel.tsx index 6eefc55b..14eb1a8b 100644 --- a/src/components/metrics/ChangeLabel.tsx +++ b/src/components/metrics/ChangeLabel.tsx @@ -6,12 +6,14 @@ import styles from './ChangeLabel.module.css'; export function ChangeLabel({ value, size, + title, reverseColors, className, children, }: { value: number; size?: 'xs' | 'sm' | 'md' | 'lg'; + title?: string; reverseColors?: boolean; showPercentage?: boolean; className?: string; @@ -19,20 +21,19 @@ export function ChangeLabel({ }) { const positive = value * (reverseColors ? -1 : 1) >= 0; const negative = value * (reverseColors ? -1 : 1) < 0; - const isNew = isNaN(value); + const neutral = value === 0 || isNaN(value); return (
- {!isNew && ( - + {!neutral && ( + )} diff --git a/src/components/metrics/MetricCard.tsx b/src/components/metrics/MetricCard.tsx index 3c4899c4..5b11156e 100644 --- a/src/components/metrics/MetricCard.tsx +++ b/src/components/metrics/MetricCard.tsx @@ -37,19 +37,21 @@ export const MetricCard = ({ return (
{showLabel &&
{label}
} - + {props?.x?.to(x => formatValue(x))} {showChange && ( - - - {changeProps?.x?.to(x => Math.abs(~~x))} - - % + + {changeProps?.x?.to(x => `${Math.abs(~~x)}%`)} )} {showPrevious && ( - + {prevProps?.x?.to(x => formatValue(x))} )}