watson/umami
1
0
Fork 0
mirror of https://github.com/umami-software/umami.git synced 2026-02-13 17:15:37 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

Feat/um 114 roles and permissions (#1683)

Browse source 
* Auth checkpoint.

* Merge branch 'dev' into feat/um-114-roles-and-permissions
This commit is contained in:
Brian Cao 2022-12-01 20:53:37 -08:00 • committed by GitHub
parent a4e80ca3e5
commit 06bebadbb9
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
27 changed files with 331 additions and 482 deletions
Download patch file Download diff file Expand all files Collapse all files

21
pages/api/users/[id]/index.ts
View file

@ -1,6 +1,5 @@
import { NextApiRequestQueryBody } from 'interface/api/nextApi';
import { checkPermission } from 'lib/auth';
import { UmamiApi } from 'lib/constants';
import { canDeleteUser, canUpdateUser, canViewUser, checkAdmin } from 'lib/auth';
import { useAuth } from 'lib/middleware';
import { NextApiResponse } from 'next';
import { badRequest, hashPassword, methodNotAllowed, ok, unauthorized } from 'next-basics';
@ -27,7 +26,7 @@ export default async (
const { id } = req.query;
if (req.method === 'GET') {
if (id !== userId) {
if (await canViewUser(userId, id)) {
return unauthorized(res);
}
@ -37,12 +36,12 @@ export default async (
}
if (req.method === 'POST') {
const { username, password } = req.body;
if (id !== userId) {
if (await canUpdateUser(userId, id)) {
return unauthorized(res);
}
const { username, password } = req.body;
const user = await getUser({ id });
const data: any = {};
@ -52,7 +51,7 @@ export default async (
}
// Only admin can change these fields
if (!(await checkPermission(req, UmamiApi.Permission.Admin))) {
if (username && (await checkAdmin(userId))) {
data.username = username;
}
@ -71,12 +70,12 @@ export default async (
}
if (req.method === 'DELETE') {
if (id === userId) {
return badRequest(res, 'You cannot delete your own user.');
if (canDeleteUser(userId)) {
return unauthorized(res);
}
if (!(await checkPermission(req, UmamiApi.Permission.Admin))) {
return unauthorized(res);
if (id === userId) {
return badRequest(res, 'You cannot delete your own user.');
}
await deleteUser(id);